This repository was archived by the owner on Oct 2, 2021. It is now read-only.
Change the way error message is surfaced up to the UI.#303
Merged
roblourens merged 1 commit intomicrosoft:masterfrom Mar 13, 2018
Merged
Change the way error message is surfaced up to the UI.#303roblourens merged 1 commit intomicrosoft:masterfrom
roblourens merged 1 commit intomicrosoft:masterfrom
Conversation
changsi-an
commented
Mar 13, 2018
| const errUserMsg = isChromeError(error) ? | ||
| error.message + ': ' + error.data : | ||
| (error.stack || error.message); | ||
| (error.message || error.stack); |
Contributor
Author
There was a problem hiding this comment.
error.message is more user friendly than error.stack(which is a stack for the DA itself, not the user code). So when reporting an error to the UI, we let error.message take priority.
The original message is put to errDiagnosticMsg, and emitted by the Output event. So we are not losing anything with this code change. If user is interested, s/he can still find the callstack in the output pane.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see the inline comment.