This repository was archived by the owner on Oct 2, 2021. It is now read-only.
Batch sending telemetry for some of the event notifications.#300
Merged
roblourens merged 2 commits intomicrosoft:masterfrom Mar 7, 2018
Merged
Batch sending telemetry for some of the event notifications.#300roblourens merged 2 commits intomicrosoft:masterfrom
roblourens merged 2 commits intomicrosoft:masterfrom
Conversation
# Conflicts: # src/chrome/chromeDebugAdapter.ts # src/utils.ts
roblourens
approved these changes
Mar 7, 2018
changsi-an
commented
Mar 7, 2018
| this._expectingStopReason = undefined; | ||
|
|
||
| smartStepP.then(should => { | ||
| await smartStepP.then(should => { |
Contributor
Author
There was a problem hiding this comment.
I add it to include the time spent in this operation in the overall measurement of onPaused event. Apart from the measurement function, no one seems to actively wait on the promise returned from this method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch-sending telemetry is necessary because some notifications from debuggee might be too frequent for the telemetry infrastructure to handle. Take VS as an example, it throttles telemetry events if there are two many within a short period of time. We will lose some important telemetry when that happens.
The BatchTelemetryReporter will cache the received telemetry events and sends them out every 10 seconds.
This PR also refactors some code and migrates some general telemetry handling code from DebugSession.ts to utils.ts or telemetry.ts.
This PR also enables telemetry for debugger.paused and debugger.onScriptParsed notification events.
This PR retargets the change to master branch.