Skip to content
This repository was archived by the owner on Dec 6, 2022. It is now read-only.

Set chrome PID in all launch cases#687

Merged
roblourens merged 1 commit intomicrosoft:masterfrom
mrcrane:chrome-pid-fix
Jun 20, 2018
Merged

Set chrome PID in all launch cases#687
roblourens merged 1 commit intomicrosoft:masterfrom
mrcrane:chrome-pid-fix

Conversation

@mrcrane
Copy link
Contributor

@mrcrane mrcrane commented Jun 20, 2018

Fixes an issue where the chrome PID was not set in some situations. In Visual Studio, without setting the PID, the chrome process will not terminate properly.

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens roblourens merged commit edd9680 into microsoft:master Jun 20, 2018
@roblourens roblourens added this to the June 2018 milestone Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants