This repository was archived by the owner on Dec 6, 2022. It is now read-only.
Now we report the times of the different tasks that happen until we launch and show the user page#610
Merged
roblourens merged 6 commits intomicrosoft:masterfrom Mar 12, 2018
Conversation
added 2 commits
March 9, 2018 17:06
…aunch and show the user page
96541b5 to
c9215ec
Compare
roblourens
reviewed
Mar 10, 2018
src/chromeDebugAdapter.ts
Outdated
| if (this._userRequestedUrl) { | ||
| // This means all the setBreakpoints requests have been completed. So we can navigate to the original file/url. | ||
| this.chrome.Page.navigate({ url: this._userRequestedUrl }); | ||
| this.events.emitMilestoneReached("RequestedNavigateToUserPage"); |
Member
There was a problem hiding this comment.
Wait on the navigate before sending the event? Maybe don't await so it doesn't block configurationDone. But just like Page.navigate(...).then(() => emitMilestoneReached())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we report the times of the different tasks that happen until we launch and show the user page