Skip to content

Makes version extraction more robust #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karthiknadig merged 2 commits into from
Sep 5, 2023
Merged

Makes version extraction more robust #306

karthiknadig merged 2 commits into from
Sep 5, 2023

Conversation

@zyxue
Copy link
Contributor

@zyxue zyxue commented Sep 5, 2023

we have a wrapper around black named black_tool.py, the version string would be

black_tool.py, version 20.8b1

and the current version extraction would fail.

@karthiknadig karthiknadig self-assigned this Sep 5, 2023
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Sep 5, 2023
@karthiknadig karthiknadig merged commit c9ce628 into microsoft:main Sep 5, 2023
@zyxue zyxue deleted the version-extraction branch September 5, 2023 22:20
@zyxue
Copy link
Contributor Author

zyxue commented Sep 5, 2023 •
edited
Loading

Thank you for merging. When will the next release be that incorporates this change?

@karthiknadig
Copy link
Member

karthiknadig commented Sep 6, 2023

This is published in pre-release version 2023.5.12490003

@karthiknadig
Copy link
Member

karthiknadig commented Sep 6, 2023

Stable release will take some time, we usually keep bug-fixes and features on insiders for a milestone.

@zyxue
Copy link
Contributor Author

zyxue commented Sep 6, 2023

This is published in pre-release version 2023.5.12490003
Nice! Curious is the pre-release automatic upon merging?

@zyxue
Copy link
Contributor Author

zyxue commented Sep 6, 2023

I see it's pre-released nightly.

curious why is there a prefixed 1 before the micro version?

vscode-black-formatter/build/update_ext_version.py

Line 50 in c9ce628

return f"1{datetime.datetime.now(tz=datetime.timezone.utc).strftime('%j%H%M')}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@anthonykim1 anthonykim1 anthonykim1 approved these changes

Assignees

@karthiknadig karthiknadig

Labels

bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zyxue @karthiknadig @anthonykim1