Skip to content

Fix debug icon. Use Codicons instead of text#98716

Merged
miguelsolorio merged 1 commit intomicrosoft:masterfrom
IllusionMH:fix-debug-icon-98704
May 28, 2020
Merged

Fix debug icon. Use Codicons instead of text#98716
miguelsolorio merged 1 commit intomicrosoft:masterfrom
IllusionMH:fix-debug-icon-98704

Conversation

@IllusionMH
Copy link
Copy Markdown
Contributor

@IllusionMH IllusionMH commented May 28, 2020

This PR fixes #98704

  1. Updated character code for debug-alt to match vscode-codicons repo change
  2. Used Codicons namespace instead of string to match other places.

/cc @misolori

UPD. Failed test on Mac looks unrelated

Copy link
Copy Markdown
Contributor

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this and updating!

@miguelsolorio miguelsolorio merged commit 1dc2f7c into microsoft:master May 28, 2020
@miguelsolorio miguelsolorio added this to the May 2020 milestone May 28, 2020
@IllusionMH IllusionMH deleted the fix-debug-icon-98704 branch May 28, 2020 13:56
@IllusionMH
Copy link
Copy Markdown
Contributor Author

@misolori thanks for review!

@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debug icon not visible in latest from master

2 participants