Skip to content

fix #98102#98127

Merged
jrieken merged 1 commit intomicrosoft:masterfrom
HaoboGu:master
May 19, 2020
Merged

fix #98102#98127
jrieken merged 1 commit intomicrosoft:masterfrom
HaoboGu:master

Conversation

@HaoboGu
Copy link
Copy Markdown
Contributor

@HaoboGu HaoboGu commented May 19, 2020

When VSCode selects preselected completion items, the index shouldn't start from 1. If there are multiple completion items with preselect=true, the first item will never be chosen.

This PR fixes #98102

When VSCode selects preselected completion items, the index shouldn't start from 1. If there are multiple completion items with preselect=true, the first item will never be chosen.
@jrieken jrieken added this to the May 2020 milestone May 19, 2020
@jrieken jrieken merged commit 4324517 into microsoft:master May 19, 2020
@jrieken
Copy link
Copy Markdown
Member

jrieken commented May 19, 2020

Thanks @HaoboGu

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VSCode preselects a wrong CompletionItem if there are multiple CompletionItem having preselect=true

2 participants