Skip to content

Add padding above hover for second line#91239

Merged
alexdima merged 2 commits intomicrosoft:masterfrom
nrayburn-tech:hover
Feb 23, 2020
Merged

Add padding above hover for second line#91239
alexdima merged 2 commits intomicrosoft:masterfrom
nrayburn-tech:hover

Conversation

@nrayburn-tech
Copy link
Copy Markdown
Contributor

Adds padding above the hover for the second line, so that the hover widget is not underneath the mouse.

Create a monaco editor.
Set the content to this.

function hello() {
	console.log("hello world");
}

Hover over console. The hover should be beneath the word console instead of over it.

This PR fixes #1810 in monaco-editor.

@alexdima alexdima self-assigned this Feb 23, 2020
@alexdima
Copy link
Copy Markdown
Member

Thank you!

@alexdima alexdima merged commit 6458842 into microsoft:master Feb 23, 2020
@alexdima alexdima added this to the February 2020 milestone Feb 23, 2020
@nrayburn-tech nrayburn-tech deleted the hover branch February 23, 2020 22:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shadow editor doesn't position hover correctly

3 participants