Add a ClipboardService to the StandaloneDiffEditor#90846
Merged
alexdima merged 5 commits intomicrosoft:masterfrom Feb 19, 2020
nrayburn-tech:master
Merged
Add a ClipboardService to the StandaloneDiffEditor#90846alexdima merged 5 commits intomicrosoft:masterfrom nrayburn-tech:master
alexdima merged 5 commits intomicrosoft:masterfrom
nrayburn-tech:master
Conversation
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a ClipboardService to the StandaloneDiffEditor, so that the tooltips for inline diffs can be used to copy the deleted lines. The implemented ClipboardService is almost identical to clipboardService.ts
Can be tested by creating a StandaloneDiffEditor with
renderSideBySide: false. Then using the icons in the margin, you should be able to copy text from the modified model.Should have the same interaction as when using the inline diff in vscode.
This PR is in relation to #1035, but should probably be left open similarly to #8226.