Style diff editor's scrollable viewport just like any other scrollbar#89660
Merged
alexdima merged 3 commits intomicrosoft:masterfrom Feb 4, 2020
robertrossmann:feat/diff-viewport-colour
Merged
Style diff editor's scrollable viewport just like any other scrollbar#89660alexdima merged 3 commits intomicrosoft:masterfrom robertrossmann:feat/diff-viewport-colour
alexdima merged 3 commits intomicrosoft:masterfrom
robertrossmann:feat/diff-viewport-colour
Conversation
|
|
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This styles the diff editor's scrollbar in the same way as any other scrollbar. As an added bonus, it now inherits the colour from the theme colour. 🎨
Before
The diff scrollbar on the right is always white and does not blend well with some themes.
After
The diff scrollbar on the right inherits the generic scrollbar's colour provided by the current theme. 🎨
Implementation notes
At this moment, I simply re-used the theme variables for regular scrollbar sliders as the thingy really looks a lot like a scrollbar slider. However, I am not opposed to the idea of introducing a completely new colour customisation variable for it.
Also note that after second thought I feel I should somehow use
registerThemingParticipant()in thegitbuiltin package to get this working, but I'll let you guide me first before I venture forth. ❤️My ultimate goal is simply to have that diff overview thingy themeable.