Input box escape \n, \r etc in the setter#74144
Conversation
|
Thanks for the PR. However I think there is a helper method which we can use and not add soo much new code. |
|
Yes I was looking for any existing method, searched with the word "escape" and could not find any, hence added a new function. Thanks for directing me to the right function. Will update the PR |
|
@isidorn Using the existing helper method is causing a cyclic dependency. Thought of moving that function into base/common/strings.ts, is that ok? |
|
There should be no change in the inputBox, it is unware of the debug world. Here are some code pointers which might help |
5f6621f to
f4cc2c7
Compare
|
Done as suggested. |
This PR aims to resolve #73975
When settings a value with newline chars to a html input element, the new line chars are getting removed.
To prevent this, just before the assignment, escaping the string value results in the expected behavior.