Fix 63749 - Markdown, U+2028, and "Go to Symbol in File..."#63936
Merged
mjbvz merged 3 commits intomicrosoft:masterfrom Nov 29, 2018
Merged
Fix 63749 - Markdown, U+2028, and "Go to Symbol in File..."#63936mjbvz merged 3 commits intomicrosoft:masterfrom
mjbvz merged 3 commits intomicrosoft:masterfrom
Conversation
Member
|
Just FYI, text buffer in VSCode/Monaco doesn't support U+2028 and U+2029 right now |
Collaborator
|
@rebornix Do you recommend this workaround? @skprabhanjan Please also add tests for this. There is skipped one already that should cover it, see 2f9f0c3 |
Contributor
Author
Added the test. (Removed the .skip) |
Collaborator
|
Thanks! The fix will be in the next VS Code insiders build and will be released with VS Code 1.30 |
Member
|
@mjbvz the change for markdown is good ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mjbvz , Added UNICODE_NEWLINE_REGEX to replace those characters, fixes #63749 .
Please review this and let me know if any changes are needed :)
Thanks.
PS: Unit tested for many cases with those
U+2028chars and it works all fine :)