Skip to content

check only dot at the end of a branch #58825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaomoreno merged 1 commit into from
Sep 18, 2018
Merged

check only dot at the end of a branch #58825

joaomoreno merged 1 commit into from
Sep 18, 2018

Conversation

@oneslash
Copy link
Contributor

@oneslash oneslash commented Sep 17, 2018 •
edited
Loading

Fixes: #58816

Branches can contain "." (dot) but not at the end or beginning.

They cannot end with a dot

https://mirrors.edge.kernel.org/pub/software/scm/git/docs/git-check-ref-format.html

@oneslash oneslash changed the title check only dot at the end of the branch check only dot at the end of a branch Sep 17, 2018
@oneslash
Copy link
Contributor Author

oneslash commented Sep 17, 2018

@joaomoreno, would you check my PR?

@octref octref requested a review from joaomoreno September 17, 2018 21:26
@joaomoreno joaomoreno added the git GIT issues label Sep 18, 2018
@joaomoreno joaomoreno added this to the September 2018 milestone Sep 18, 2018
@joaomoreno joaomoreno merged commit d26c044 into microsoft:master Sep 18, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Sep 18, 2018

Thanks! 🎆

@oneslash oneslash deleted the 58816 branch September 18, 2018 08:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joaomoreno joaomoreno Awaiting requested review from joaomoreno

Assignees

@joaomoreno joaomoreno

Labels

git GIT issues

Projects

None yet

Milestone

September 2018

Development

Successfully merging this pull request may close these issues.

Invalid branch name in code insiders

2 participants

@oneslash @joaomoreno