Skip to content

Fix for issue #39458#52506

Merged
jrieken merged 2 commits intomicrosoft:masterfrom
bitshiftza:master
Jun 21, 2018
Merged

Fix for issue #39458#52506
jrieken merged 2 commits intomicrosoft:masterfrom
bitshiftza:master

Conversation

@bitshiftza
Copy link
Contributor

@bitshiftza bitshiftza commented Jun 20, 2018

Fixes #39458
Implemented algorithm for determining code preview popup content based off matching brackets.

@bitshiftza
Copy link
Contributor Author

@jrieken Closed the previous PR #52259 (made a small mess). This one has the algorithm implemented with the changes you suggested in the previous PR.

@jrieken jrieken added the editor-symbols definitions, declarations, references label Jun 21, 2018
@jrieken jrieken added this to the June 2018 milestone Jun 21, 2018
@jrieken
Copy link
Member

jrieken commented Jun 21, 2018

lgtm. thanks @bitshiftza

@jrieken jrieken merged commit ed788cf into microsoft:master Jun 21, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
@hediet
Copy link
Member

hediet commented Apr 8, 2022

I did not manage to trigger getPreviewRangeBasedOnBrackets by using the PHP or TypeScript language server.
Since targetSelectionRange seems to be set always in my experiments, I assume getPreviewRangeBasedOnBrackets is no longer needed.

As there are no tests for this code and the code is hard to read and undocumented, I removed it in 1d7f844.

This helps me to refactor findNextBracket, as this piece of code no longer holds me hostage.

I'm sure the new bracket pair matching API would make this algorithm obsolete anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

editor-symbols definitions, declarations, references

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants