Skip to content

[Fix] Add a missing return type for _hue2rgb #51285

Merged
aeschli merged 1 commit intomasterfrom
unknown repository
Jun 7, 2018
Merged

[Fix] Add a missing return type for _hue2rgb #51285
aeschli merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jun 7, 2018

Change Logs:

  1. /vscode/src/vs/base/common/color.ts:
    _hue2rgb should have a return type in ts. The type shouldn't be missing.

@aeschli aeschli merged commit d5961f5 into microsoft:master Jun 7, 2018
@aeschli
Copy link
Contributor

aeschli commented Jun 7, 2018

Thanks @MaleDong !

@aeschli aeschli added this to the June 2018 milestone Jun 7, 2018
@aeschli aeschli self-assigned this Jun 7, 2018
@ghost
Copy link
Author

ghost commented Jun 7, 2018

Nothing special :)
BTW:It seems that your build tool is wrong……? Publish part isn't working properly?!
:D

@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant