Adding warning when tokenization is skipped#51265
Merged
alexdima merged 2 commits intomicrosoft:masterfrom Jun 11, 2018
Merged
Conversation
Contributor
|
Cool. You probably dont want to show a dialog per line, but once for the document. Also you don't want to show it every time again when the line is tokenized. |
Contributor
Author
|
@aeschli you are right. That's fixed now. I wonder if we should also add a configuration property to not show this warning message. In case you think is a good idea, please let me know how it should be called so I can add it. |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #51127.
Here how it looks:
cc: @aeschli @alexandrudima