Await git.pullFrom and gitt.pushTo to ensure any failures display an …#49167
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Jun 18, 2018
Merged
Await git.pullFrom and gitt.pushTo to ensure any failures display an …#49167joaomoreno merged 1 commit intomicrosoft:masterfrom
joaomoreno merged 1 commit intomicrosoft:masterfrom
Conversation
…error dialog to the user
Author
|
Refers to #41519. |
Author
|
This just adds two 'await' statements to ensure that if git.pushTo or git.pullFrom fail when using the Command Palette, the failure is not silent. Instead, the user is notified with an error dialog. |
loridawn
reviewed
Jun 17, 2018
|
|
||
| const remoteCharCnt = remotePick.label.length; | ||
|
|
||
| repository.pullFrom(false, remotePick.label, branchPick.label.slice(remoteCharCnt + 1)); |
Member
|
Great fix! Thanks! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…error dialog to the user