Skip to content

Markdown Security Policy to allow local HTTP content#46473

Merged
mjbvz merged 1 commit intomicrosoft:masterfrom
anoff:feature/CSP-localhost
Mar 26, 2018
Merged

Markdown Security Policy to allow local HTTP content#46473
mjbvz merged 1 commit intomicrosoft:masterfrom
anoff:feature/CSP-localhost

Conversation

@anoff
Copy link
Contributor

@anoff anoff commented Mar 24, 2018

fixes #46418

Added another Security Policy option that allows image, media, style and font data to be loaded via (unsafe) http from localhost and 127.0.0.1. Even though Google CSP Evaluator recommends adding object-src to prevent injection I refrained from adding it would deviate from the standard set by the existing policies. Maybe worth updating all of them in one PR?

screen shot 2018-03-24 at 12 37 07

Steps taken to test:

  • ran tests: 3934 passing
  • successful local build for darwin
  • tested new policy that it won't load http:// from www but will load from localhost web server

@msftclas
Copy link

msftclas commented Mar 24, 2018

CLA assistant check
All CLA requirements met.

@mjbvz mjbvz added this to the March 2018 milestone Mar 26, 2018
@mjbvz mjbvz merged commit e64b9b4 into microsoft:master Mar 26, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 26, 2018

Great! This will be in the insiders build and should go out in VS Code 1.22

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature MD Preview: Enable unsafe content from localhost

3 participants