Focus terminal after toggling via workbench.action.terminal.toggleTerminal#46272
Merged
Tyriar merged 2 commits intomicrosoft:masterfrom Mar 22, 2018
usernamehw:focus_terminal
Merged
Focus terminal after toggling via workbench.action.terminal.toggleTerminal#46272Tyriar merged 2 commits intomicrosoft:masterfrom usernamehw:focus_terminal
workbench.action.terminal.toggleTerminal#46272Tyriar merged 2 commits intomicrosoft:masterfrom
usernamehw:focus_terminal
Conversation
Tyriar
reviewed
Mar 22, 2018
| this.terminalService.getActiveInstance().focus(); | ||
| toDispose.dispose(); | ||
| }); | ||
| this.terminalService.createInstance(undefined, true); |
Member
There was a problem hiding this comment.
I think it would be safer to keep a reference to the ITerminalInstance created here and make sure that it's correct before you focus/dispose the listener
Member
|
@usernamehw works great 👍
This is as designed, the editor is always focused even if you had any panel/viewlet focused. |
Contributor
Author
Looks like extensions viewlet is somehow an exception... |
Member
|
@usernamehw I think this might actually be a bug, focus is sent to the extension viewlet even when it didn't have focus before. @joaomoreno? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly mitigates #40416 (only for the command). 2 items left:
This is not a WIP, I am only interested in the command fix, as of now.
cc @Tyriar