Avoid accessing vsWorker of undefined / null value#46012
Merged
alexdima merged 1 commit intomicrosoft:masterfrom Mar 26, 2018
jjyyxx:master
Merged
Avoid accessing vsWorker of undefined / null value#46012alexdima merged 1 commit intomicrosoft:masterfrom jjyyxx:master
alexdima merged 1 commit intomicrosoft:masterfrom
jjyyxx:master
Conversation
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to microsoft/monaco-editor#766, I made small changes to the code. The
messagemight benullifserializedMessage === 'null'orundefinedif theJSON.parsethrows aSyntaxError. So the code should check the nullity first.Monaco editor itself, I think, will not make invalid messages like this. But other message source(like webpack) which is not intended for monaco editor may lead to this error.