Fixes #21423 | Add ANSI colour tokens as children of existing tokens#45946
Merged
isidorn merged 1 commit intomicrosoft:masterfrom Mar 19, 2018
Merged
Fixes #21423 | Add ANSI colour tokens as children of existing tokens#45946isidorn merged 1 commit intomicrosoft:masterfrom
isidorn merged 1 commit intomicrosoft:masterfrom
Conversation
Collaborator
|
Thanks for your great PR 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#21423
Previous implementation was appending new
<span>elements to the same node, rather than finding the deepest node each time and appending to that. I added a loop to find the deepest child and append, ensuring that new tokens are nested as desired.