Enable search of local Typescript Language Service Plugins (fix #45856)#45858
Enable search of local Typescript Language Service Plugins (fix #45856)#45858mjbvz merged 2 commits intomicrosoft:masterfrom
Conversation
|
|
mjbvz
left a comment
There was a problem hiding this comment.
Looking good. Just a few small changes
There was a problem hiding this comment.
Should be array contents comparison
extensions/typescript/package.json
Outdated
There was a problem hiding this comment.
Add "isExecutable": true here. This prevents this from ever being used as a workspace setting
There was a problem hiding this comment.
Why do you think it should be a user-only setting?
Specifying pluginPaths on workspace level can be quite useful, especially in conjunction with relative paths. In this case plugins configuration can be committed to a source control and shared between team members.
If this is this because of the security concerns, I don't believe this is a more dangerous option than ability to specify typescript.tsdk on a workspace-level.
There was a problem hiding this comment.
Yes it is for security reasons. Tsdk asks for user confirmation before executing any code in the workspace but that flow is complicated so I don't want to duplicate it here. Instead we should just limit these this to be a user only setting
|
@mjbvz Changes have been made according to your comments. |
f5c8e12 to
9c43780
Compare
…discovery locations
…, setting made executable
|
Thanks! On track for the March vscode release |
Proposed change for #45856. Added option to discover plugins in project-local node modules