Properly set electron version in env scripts#45696
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Mar 14, 2018
SteveDesmond-ca:master
Merged
Properly set electron version in env scripts#45696joaomoreno merged 1 commit intomicrosoft:masterfrom SteveDesmond-ca:master
joaomoreno merged 1 commit intomicrosoft:masterfrom
SteveDesmond-ca:master
Conversation
Member
|
Oh wow. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the
console.log()got removed frombuild/lib/electron.js, thenpm_config_targetenvironment variable wasn't getting set to anything.This PR updates the scripts to call the
getElectronVersion()method onbuild/lib/electron.js.