Show warning when git commit input box only contains whitespaces#45254
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Jun 4, 2018
Merged
Show warning when git commit input box only contains whitespaces#45254joaomoreno merged 1 commit intomicrosoft:masterfrom
joaomoreno merged 1 commit intomicrosoft:masterfrom
Conversation
Contributor
Author
|
@joaomoreno after submitting this PR, I realized even though the issue was about line breaks but other white space characters may apply here too. For example, a mix of line breaks and empty spaces... My current approach is to see if the commit message is all line breaks (using \r?\n), do you think matching whitespaces (\s) instead is a better approach? |
Member
|
@gnijuohz Yeah I think whitespace makes more sense. |
Contributor
Author
|
@joaomoreno thanks! I'll update my PR. |
Contributor
Author
|
PR updated :) |
Member
|
Thanks! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #45031.
A warning message 'Current commit message only contains line breaks' will be shown when
git.inputValidationis not set to 'off' and all the user has entered in the commit message box are line breaks.