Add defining span to definition provider API#45249
Closed
Conversation
Member
|
Based on current plan stretch for March esp. since we should understand what this means to ImplementationProviders, GoToTypeDefProvider |
Collaborator
Author
|
Yes good to consider those other providers too for the design of the api, but we only need the defining symbol range for the |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #40045
Problem
See #10037
Proposal
Adds a new
resolveDefinitionContexttoDefinitionProvider. This allows a definition provider to return the defining symbol span.