Skip to content

Enabled 'Open to the side' command only for files#44968

Merged
isidorn merged 2 commits intomicrosoft:masterfrom
oriash93:oriash93/44676
Mar 5, 2018
Merged

Enabled 'Open to the side' command only for files#44968
isidorn merged 2 commits intomicrosoft:masterfrom
oriash93:oriash93/44676

Conversation

@oriash93
Copy link
Contributor

@oriash93 oriash93 commented Mar 3, 2018

I'm not totally sure if that's the optimal solution, but it works for markdown preview files (as stated in the issue) and for the Welcome page (which acts the same).

resolves #44676

@mjbvz mjbvz requested a review from bpasero March 5, 2018 07:45
@bpasero bpasero requested review from isidorn and removed request for bpasero March 5, 2018 08:50
@isidorn
Copy link
Collaborator

isidorn commented Mar 5, 2018

@oriash93 thanks for your PR. I think this makes sense as the current wlecome page and the open to the side do not work. So let's disable it for now.
However the .isFile is a subset of has resource, so I will change your .and clause to simply be isFIle 9e6944d

@isidorn isidorn merged commit f9dbfb4 into microsoft:master Mar 5, 2018
@isidorn isidorn added this to the March 2018 milestone Mar 5, 2018
@isidorn isidorn self-assigned this Mar 5, 2018
@oriash93
Copy link
Contributor Author

oriash93 commented Mar 5, 2018

Did not know that, always good to learn.
Thanks!

@oriash93 oriash93 deleted the oriash93/44676 branch March 15, 2018 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Open to the Side' button in context menu for markdown preview should be removed

3 participants