Improve Call Stack performance with many threads, fixes #44248#44249
Improve Call Stack performance with many threads, fixes #44248#44249isidorn merged 1 commit intomicrosoft:masterfrom
Conversation
9add8be to
b27256c
Compare
b27256c to
96f67c7
Compare
|
@isidorn change looks good and makes sense to me. |
|
@rsalvador Thanks a lot for your PR. I left comments directly in the code, once you address those we could merge this in. |
There was a problem hiding this comment.
Instead of a timeoue please use a Scheduler.
An example usage can be found here https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/electron-browser/callStackView.ts#L38
|
@rsalvador Also before we accpet this change I would still need convincing vscode blocks the UI. Since I like what we are already doing - we are refreshing the callstack view with a 50ms delay. So if multiple changes come in that range we will only refresh once. Do you still see the vscode blocking if you change this 50ms to 200 ms for example here https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/electron-browser/callStackView.ts#L82 Including @testforstephen to see if this can be fixed on the Java extension side. Even though vscode UI should protect against such behavior from an extension. |
|
@isidorn thank for looking into this! |
|
@rsalvador thanks for more details. I will look into this in greater details next week. Until then we can also get @testforstephen feedback |
|
Looks good. The fix could help to reduce the |
There was a problem hiding this comment.
I would prefer if this was called fetchThreadsSchedulers
There was a problem hiding this comment.
I would prefer if this method was inlined
There was a problem hiding this comment.
Also please add a one line comment about why we are debouncing
There was a problem hiding this comment.
scheduler should be added to toDisposeOnSessionEnd so it gets properly disposed
|
@rsalvador I have commented in the code - mostly polish. |
|
@isidorn performed all changes and rebased/resolved |
|
@rsalvador thanks a lot. Looks good to me, let's merge it in. |
No description provided.