make the timeout for formatOnSave configurable#43702
Merged
jrieken merged 2 commits intomicrosoft:masterfrom Mar 2, 2018
buyology:formatOnSave-timeout
Merged
make the timeout for formatOnSave configurable#43702jrieken merged 2 commits intomicrosoft:masterfrom buyology:formatOnSave-timeout
jrieken merged 2 commits intomicrosoft:masterfrom
buyology:formatOnSave-timeout
Conversation
| 'overridable': true, | ||
| 'scope': ConfigurationScope.RESOURCE | ||
| }, | ||
| 'editor.formatOnSaveTimeout': { |
There was a problem hiding this comment.
Setting is editor-global, it will be hard for end user to figure out correct timeout as it depends on the language and the machine speed.
Contributor
Author
There was a problem hiding this comment.
True. Made it overridable, then at least every extension that identifies this as a potential issue can provide a sane default (and the user the opportunity to configure it for that specific usage).
Contributor
Author
|
Any update on this @jrieken? |
|
+1 I was about to put up a PR for the same thing. |
Member
|
Back from vacations... Too late for Feb-endgame but will take a look in March. |
jrieken
approved these changes
Mar 1, 2018
Member
jrieken
left a comment
There was a problem hiding this comment.
Looks good. I will merge as soon as master is open for business again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41194
As reported by users of extensions for
TypeScript,Python,rubyandgoformatOnSave-commands can take longer than the hard coded750 ms, e.g. for large projects or complex commands.This removes the hardcoded value and instead makes it user configurable.