Skip to content

Simplify check lang.mimetypes#42932

Merged
alexdima merged 1 commit intomicrosoft:masterfrom
Connormiha:optimize-merge-lang
Mar 26, 2018
Merged

Simplify check lang.mimetypes#42932
alexdima merged 1 commit intomicrosoft:masterfrom
Connormiha:optimize-merge-lang

Conversation

@Connormiha
Copy link
Contributor

This PR simplify mergeLanguage

  1. Remove needless check for type undefined, because Array.isArray doesn't pass undefined, null, etc.
  2. Get rid of for loop and use native push + spread
  3. Don't check primaryMime in each step. Just pull from first element.

@alexdima alexdima self-assigned this Feb 5, 2018
@alexdima alexdima added this to the March 2018 milestone Mar 26, 2018
@alexdima alexdima merged commit 5267caa into microsoft:master Mar 26, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants