Merged
Conversation
Doesn't edit the model unless an edit is required, which means the undo stack is updated properly. Behaviour should be similar to trimTrailingWhitespace
Member
|
@AiryShift thanks for your continuous contribution on this! I've added a test case which
in 838189f . You can take a look and play with it. Without your change, the test would fail. Thanks again for your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't edit the model unless an edit is required, which means the undo stack is updated properly. Behaviour should be similar to
files.trimTrailingWhitespace. I'm not sure how to test the behaviour to prevent a future regression though, if someone could clarify?Closed #39844 because the commit provided the wrong issue number.