Change label of indentation action in status bar#37515
Change label of indentation action in status bar#37515alexdima merged 2 commits intomicrosoft:masterfrom
Conversation
This change is to conform to the labels of the other actions, which clearly indicate that they will provide a way to *do* something (Go to, Select, etc.)
|
@waldyrious as noted in the header of these files they are machine generated. The way to contribute to translations is via Transifex. Please see https://github.com/Microsoft/Localization/wiki/Visual-Studio-Code-Community-Localization-Project |
|
@dbaeumer should I drop bc152db and 0b583f6, then? And what about the key change -- is that OK? |
|
@waldyrious the keys are in our source code and need to be changed there . The translation is managed in transifex and need to be changed there. For example src/vs/workbench/browser/parts/editor/editorStatus.ts for the corresponding file you changed in i18n. |
|
@dbaeumer just to be sure, are you saying that commit 5876213 can remain in this PR? |
|
No, For example the first change has to happen here: https://github.com/Microsoft/vscode/blob/master/src\vs\workbench\browser\parts\editor\editorStatus.ts#L308 |
@dbaeumer 5876213 does change that (here). Are you saying that that change must happen in isolation (i.e. that 5876213 should only contain the change to |
|
The key change has to happen in our source code. Then in transifex the message (since it is still the same will be recycled) and when we import the next time from transfix the key change will appear in the i18n files. Message changes have to appear in Transifex itself. What is the purpose of the key change? Usually we only change them if absolutely necessary. |
Got it, thanks for the confirmation. I'll update the branch accordingly.
The change in the key is to keep it consistent with both the message contents and the other keys: -indentation --> "Indentation"
+selectIndentation --> "Select Indentation"
selectEncoding --> "Select Encoding"
selectEOL --> "Select End of Line Sequence"
selectLanguageMode --> "Select Language Mode"If I changed only the message contents, then the key name would be inconsistent and potentially confusing. |
This is to match both its contents and the keys of similar actions in the status bar
0b583f6 to
32357e9
Compare
|
@dbaeumer , it is code change. So assigned back to you. |
|
This is editor. Assigning to @alexandrudima |
This change is to conform to the labels of the other actions, which clearly indicate that they will provide a way to do something ("Go to", "Select", etc.)
I separated the changes into multiple atomic commits, so that if any of the changes are not acceptable (e.g. changes to the localization keys, or localization updates that don't go through Transifex), they can be easily left out.