Skip to content

Conversation

@aozgaa
Copy link
Contributor

@aozgaa aozgaa commented Sep 22, 2017

Adds a telemetry event to record errors generated by tsserver.

Note that this records all error-responses from tsserver except cancellations. This includes:

  • errors thrown while processing a request (we parse out the message and stack in this case)
  • requests that do not generate a response when one is expected
  • unrecognized JSON commands the server is asked to execute

These events should not be raised often, but part of the reason we would like to get information about these is that we really don't know, since tsserver swallows the errors and continues to run.

@mjbvz mjbvz self-requested a review September 22, 2017 22:34
@mjbvz mjbvz self-assigned this Sep 22, 2017
@mjbvz mjbvz merged commit c8f5358 into microsoft:master Sep 25, 2017
@mjbvz mjbvz added this to the September 2017 milestone Sep 25, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants