-
Notifications
You must be signed in to change notification settings - Fork 37.4k
Replace bash shebang with '#!/usr/bin/env bash" for portability #34543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There is no Electron for FreeBSD. Did you hit some actual issue? |
|
I'm trying to port VS Code to FreeBSD. So, this PR is a first step. |
Tyriar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does seem to be the best for portability 👍 https://stackoverflow.com/a/10383546/1156119
|
Thanks! |
|
@Tyriar This broke your publish scripts: This is why I don't like PRs which don't fix an actual problem. Reverted that file: d99c7d8 |
|
Sorry for the problems. I will investigate these problems later when I have free time. |
|
not sure if you figured this out already, but |
|
@jshap70 that was the first problem that was hit |
The example system that does not put
bashin a/bindirectory is FreeBSD. Instead, they put it inside/usr/local/bin.