add closeOnResult for editor's find widget#299865
Merged
meganrogge merged 2 commits intomainfrom Mar 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new editor find setting to automatically close the Find widget after an explicit navigation command successfully lands on a match, aligning Ctrl+F → Enter workflows more closely with “jump to match then keep editing”.
Changes:
- Introduces
editor.find.closeOnResultto editor find options (config schema + Monaco typings). - Implements close-on-result behavior in
matchFindActionfor next/previous match navigation. - Updates accessibility help and adds unit tests covering the new setting behavior.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/codeEditor/browser/editorFindAccessibilityHelp.ts | Documents the new editor.find.closeOnResult setting in Find accessibility help. |
| src/vs/monaco.d.ts | Adds closeOnResult to monaco.editor.IEditorFindOptions typings. |
| src/vs/editor/contrib/find/test/browser/findController.test.ts | Adds tests validating close behavior on match / no match / setting disabled. |
| src/vs/editor/contrib/find/browser/findController.ts | Implements the close-on-result behavior during next/previous match actions. |
| src/vs/editor/common/config/editorOptions.ts | Adds editor.find.closeOnResult setting with default + validation + schema description. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rebornix
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #264818