Skip to content

Reinstate symbol icon colors in quickpicks (fix #299650)#299753

Merged
mrleemurray merged 10 commits into
microsoft:mainfrom
gjsjohnmurray:fix-299650
Jun 4, 2026
Merged

Reinstate symbol icon colors in quickpicks (fix #299650)#299753
mrleemurray merged 10 commits into
microsoft:mainfrom
gjsjohnmurray:fix-299650

Conversation

@gjsjohnmurray

@gjsjohnmurray gjsjohnmurray commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR fixes #299650

image

Copilot AI review requested due to automatic review settings March 6, 2026 12:35
Copilot AI reviewed Mar 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #299650 by restoring symbol-kind icon colors in quick pick UIs (e.g., “Go to Symbol”) by opting rendered codicon markup into the workbench’s symbol color styling.

Changes:

  • Extend renderLabelWithIcons / renderIcon to optionally add the codicon-colored CSS class.
  • Update HighlightedLabel to render embedded icons with codicon-colored enabled when supportIcons is true.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/vs/base/browser/ui/iconLabel/iconLabels.ts Adds an opt-in flag to append codicon-colored to rendered icon spans.
src/vs/base/browser/ui/highlightedlabel/highlightedLabel.ts Enables colored icon rendering for icon markup rendered via HighlightedLabel.

Comment thread src/vs/base/browser/ui/iconLabel/iconLabels.ts
Comment thread src/vs/base/browser/ui/iconLabel/iconLabels.ts
Comment thread src/vs/base/browser/ui/highlightedlabel/highlightedLabel.ts
Comment thread src/vs/base/browser/ui/highlightedlabel/highlightedLabel.ts
mrleemurray
mrleemurray reviewed Mar 9, 2026
View reviewed changes

@mrleemurray mrleemurray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gjsjohnmurray looks good - please add some tests to cover the new behaviour & I will re-test :)

@alythobani

alythobani commented Apr 6, 2026

Copy link
Copy Markdown

Hi! FYI I think #299479 is a directly related issue to this as well.

Copilot AI reviewed Apr 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread src/vs/base/browser/ui/iconLabel/iconLabels.ts
@gjsjohnmurray gjsjohnmurray mentioned this pull request Apr 8, 2026
Open
@gjsjohnmurray

gjsjohnmurray commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

@gjsjohnmurray looks good - please add some tests to cover the new behaviour & I will re-test :)

@mrleemurray test added, please review.

@gjsjohnmurray

gjsjohnmurray commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

Please can this be milestoned for 1.116.0?

@gjsjohnmurray

gjsjohnmurray commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

Please can this be milestoned for 1.116.0?

Or 1.117.0?

@gjsjohnmurray

gjsjohnmurray commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

@mrleemurray can I do anything to help progress this?

@gjsjohnmurray

gjsjohnmurray commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

@mrleemurray another nudge

@gjsjohnmurray

gjsjohnmurray commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Thanks both. Please merge.

@mrleemurray mrleemurray merged commit d1aa998 into microsoft:main Jun 4, 2026
25 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.124.0 milestone Jun 4, 2026
@vs-code-engineering vs-code-engineering Bot mentioned this pull request Jun 4, 2026
Closed
@gjsjohnmurray gjsjohnmurray deleted the fix-299650 branch June 8, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@connor4312 connor4312 connor4312 approved these changes

@mrleemurray mrleemurray mrleemurray approved these changes

Assignees

@mrleemurray mrleemurray

Labels

None yet

Projects

None yet

Milestone

1.124.0

Development

Successfully merging this pull request may close these issues.

Go to symbol UI symbols have no colors

5 participants

@gjsjohnmurray @alythobani @connor4312 @mrleemurray