fix: cancel debug launch when ESC is pressed on input variable dialog#293837
Merged
connor4312 merged 3 commits intomicrosoft:mainfrom Feb 17, 2026
Merged
fix: cancel debug launch when ESC is pressed on input variable dialog#293837connor4312 merged 3 commits intomicrosoft:mainfrom
connor4312 merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
connor4312
previously approved these changes
Feb 10, 2026
DonJayamanne
previously approved these changes
Feb 10, 2026
auto-merge was automatically disabled
February 10, 2026 13:03
Head branch was pushed to by a user without write access
86acfff
connor4312
approved these changes
Feb 17, 2026
TylerLeonhardt
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248716
When a user cancels a
pickString(or other input variable) dialog by pressing ESC during a debug launch, the launch incorrectly continues with the unresolved${input:...}string instead of aborting.Root Cause
resolveWithInteractionReplacewas ignoring the return value ofresolveWithInteraction, which returnsundefinedwhen the user cancels the input. As a result, even after cancellation,parsed.toObject()was called and returned the config with the raw${input:...}placeholder string, causing the launch to proceed.Changes
baseConfigurationResolverService.ts: Check the return value ofresolveWithInteractioninresolveWithInteractionReplace. If it returnsundefined(user canceled), propagateundefinedinstead of callingparsed.toObject().debugger.ts: Update the return type ofsubstituteVariablestoPromise<IConfig | undefined>to reflect that variable resolution can be canceled.configurationResolverService.test.ts: Add a test that verifiesresolveWithInteractionReplacereturnsundefinedwhen the user cancels input.After this fix, pressing ESC on the pickString dialog correctly aborts the launch: