Skip to content

chore: update node-pty@1.2.0-beta.10#291471

Merged
deepak1556 merged 1 commit into
mainfrom
robo/update_pty
Jan 29, 2026
Merged

chore: update node-pty@1.2.0-beta.10#291471
deepak1556 merged 1 commit into
mainfrom
robo/update_pty

Conversation

@deepak1556

Copy link
Copy Markdown
Collaborator

Fixes #182212

@deepak1556 deepak1556 added this to the January 2026 milestone Jan 29, 2026
@deepak1556 deepak1556 self-assigned this Jan 29, 2026
Copilot AI review requested due to automatic review settings January 29, 2026 02:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the node-pty dependency from version 1.2.0-beta.8 to 1.2.0-beta.10 to address a TTY file descriptor leak issue reported in #182212, where VS Code was leaking /dev/ptmx file descriptors on macOS, eventually exhausting available TTY resources.

Changes:

  • Updated node-pty dependency to version 1.2.0-beta.10 in both main and remote package configurations

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Updated node-pty dependency version from ^1.2.0-beta.8 to ^1.2.0-beta.10
package-lock.json Updated node-pty resolved version and integrity hash to match 1.2.0-beta.10
remote/package.json Updated node-pty dependency version from ^1.2.0-beta.8 to ^1.2.0-beta.10
remote/package-lock.json Updated node-pty resolved version and integrity hash to match 1.2.0-beta.10
Files not reviewed (1)
  • remote/package-lock.json: Language not supported

@deepak1556 deepak1556 marked this pull request as ready for review January 29, 2026 04:23
@deepak1556 deepak1556 enabled auto-merge (squash) January 29, 2026 04:23
@deepak1556 deepak1556 merged commit 7d83ce8 into main Jan 29, 2026
28 checks passed
@deepak1556 deepak1556 deleted the robo/update_pty branch January 29, 2026 04:52
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Mar 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vscode leaking tty fd's

3 participants