Fix bug where a format document command results in an unknown detailed reason#288934
Merged
hediet merged 5 commits intomicrosoft:mainfrom Jan 29, 2026
Merged
Fix bug where a format document command results in an unknown detailed reason#288934hediet merged 5 commits intomicrosoft:mainfrom
hediet merged 5 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@Tyriar fyi - seems like a new PR flow is not running checks without approval and seems to to be notifying reviewers until the checks run. |
Member
|
@a-stewart this has been the case for quite a while now, it's annoying but important for security unfortunately. |
Contributor
Author
|
@hediet - friendly ping on this - not sure if assigning notifies you. |
hediet
approved these changes
Jan 28, 2026
Tyriar
approved these changes
Jan 28, 2026
Contributor
Author
|
Thanks - I don't think I have permission to merge this, even after it is approved though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you run Format Document on a file with a formatter provided by an extension, the detailed reason is:
{source: 'unknown', name: undefined}.The reason that the
nameisundefinedis that in codeEditorWidget.ts, the name is set tosourceStr, butsourceStris not set until the line below, as such it is called withname: undefined.This PR should fix that.
I'll also send a more comprehensive PR which will also pass through the provider id as that seems to be missing here too.