Remove forced layout from terminal command guide #285035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could not reproduce the issue in OSS, this should remove the forced layout though. Fixes #285032
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a forced layout calculation from the terminal command guide feature by replacing dynamic JavaScript-based margin calculation with static CSS. This should improve performance by avoiding unnecessary layout recalculations.
- Removes
getComputedStylecall that was dynamically calculating the terminal element's padding - Adds a static
-20pxmargin-left CSS rule that matches the terminal's fixed 20px left padding
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminal/browser/xterm/markNavigationAddon.ts | Removes the JavaScript code that dynamically calculated and applied margin-left based on computed padding |
| src/vs/workbench/contrib/terminal/browser/media/terminal.css | Adds static margin-left: -20px rule to .terminal-command-guide to replace the dynamic calculation |
lszomoru
approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not reproduce the issue in OSS, this should remove the forced layout though.
Fixes #285032
cc @meganrogge