fix: memory leak in terminal chat widget #284325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in terminal chat widget.
Details
When toggling terminal inline chat, this disposable seems to be registered each time, making the number of registered disposables grow by 1 each time when opening the terminal inline chat
Fix
Changing the code to use a
MutableDisposableensures that at most one session disposable registered.Before
When opening and closing terminal inline 97 times, the number of functions in
TerminalChatWidgetseems to grow by 1 each timeAfter
No more leak is detected.