Fix FormatOnSave when modificationsIfAvailable
#283726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
modificationsIfAvailable
lszomoru
approved these changes
Dec 16, 2025
Member
|
@RedCMD, thank you very much for your contribution! |
aiday-mar
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241795 #253840
Unable to read fileerror #253840the Git extension was not ignoring ignored files when asked for original resource
causing diff to fail to open non-existence files
this allows FormatOnSave to work on ignored files when
"editor.formatOnSaveMode": "modificationsIfAvailable"is setpath I followed:
vscode/src/vs/workbench/contrib/codeEditor/browser/saveParticipants.ts
Line 260 in a24e66c
vscode/src/vs/workbench/contrib/format/browser/formatModified.ts
Line 56 in a24e66c
vscode/src/vs/workbench/contrib/scm/common/quickDiffService.ts
Line 154 in a24e66c
vscode/src/vs/workbench/contrib/scm/common/quickDiffService.ts
Line 94 in a24e66c
vscode/src/vs/workbench/api/browser/mainThreadSCM.ts
Line 425 in a24e66c
vscode/src/vs/workbench/api/common/extHostSCM.ts
Line 1049 in a24e66c
vscode/extensions/git/src/repository.ts
Line 1097 in a24e66c