Add support for rename inline suggestions#279147
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces support for inline suggestions that enable automatic rename refactoring when accepting code completions. When an inline completion involves renaming a symbol, the system detects this and offers to perform the rename operation across the codebase.
Key changes include:
- Added a new
RenameSymbolProcessorclass that analyzes inline completion edits to detect rename operations - Extended the inline completion API with a
supportsRenameproperty to indicate rename capability - Added telemetry tracking for rename operations (creation status, duration, timeout)
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.inlineCompletionsAdditions.d.ts | Added supportsRename property to proposed inline completion API |
| src/vs/workbench/api/common/extHostLanguageFeatures.ts | Extended inline completion adapter to pass supportsRename flag to main thread |
| src/vs/workbench/api/browser/mainThreadLanguageFeatures.ts | Added rename telemetry fields to lifetime summary |
| src/vs/monaco.d.ts | Added supportsRename property and renamed InlineCompletionHint to IInlineCompletionHint, added rename telemetry properties |
| src/vs/editor/contrib/rename/browser/rename.ts | Exported new prepareRename function for rename validation |
| src/vs/editor/contrib/inlineCompletions/browser/telemetry.ts | Added telemetry classification for rename tracking fields |
| src/vs/editor/contrib/inlineCompletions/browser/model/renameSmbolProcessor.ts | New processor class that detects and proposes rename refactorings from inline completions |
| src/vs/editor/contrib/inlineCompletions/browser/model/provideInlineCompletions.ts | Added RenameInfo type and support for rename commands in suggestion data |
| src/vs/editor/contrib/inlineCompletions/browser/model/inlineSuggestionItem.ts | Added rename-related properties and methods to suggestion items |
| src/vs/editor/contrib/inlineCompletions/browser/model/inlineCompletionsSource.ts | Integrated rename processor into suggestion pipeline |
| src/vs/editor/contrib/inlineCompletions/browser/model/inlineCompletionsModel.ts | Added rename command execution when accepting completions |
| src/vs/editor/contrib/inlineCompletions/browser/controller/commandIds.ts | Added rename symbol command identifier |
| src/vs/editor/common/languages.ts | Added supportsRename to InlineCompletion, renamed InlineCompletionHint to IInlineCompletionHint, added rename fields to LifetimeSummary |
src/vs/editor/contrib/inlineCompletions/browser/model/inlineCompletionsSource.ts
Outdated
Show resolved
Hide resolved
src/vs/editor/contrib/inlineCompletions/browser/model/renameSymbolProcessor.ts
Show resolved
Hide resolved
src/vs/editor/contrib/inlineCompletions/browser/model/provideInlineCompletions.ts
Show resolved
Hide resolved
src/vs/editor/contrib/inlineCompletions/browser/model/provideInlineCompletions.ts
Show resolved
Hide resolved
src/vs/editor/contrib/inlineCompletions/browser/model/renameSymbolProcessor.ts
Show resolved
Hide resolved
src/vs/editor/contrib/inlineCompletions/browser/model/renameSmbolProcessor.ts
Outdated
Show resolved
Hide resolved
src/vs/editor/contrib/inlineCompletions/browser/model/renameSymbolProcessor.ts
Show resolved
Hide resolved
src/vs/editor/contrib/inlineCompletions/browser/model/renameSmbolProcessor.ts
Outdated
Show resolved
Hide resolved
aiday-mar
previously approved these changes
Nov 24, 2025
…bolProcessor.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aiday-mar
previously approved these changes
Nov 24, 2025
sandy081
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Introduce support for inline suggestions that allow renaming symbols.closes #277818