chat: add additional timing information on the model#278449
Merged
connor4312 merged 2 commits intomainfrom Nov 19, 2025
Merged
Conversation
- Add a public created `timestamp` on the IChatModel
- Add a started `timestamp` and optional `completedAt` timestamp on
the IChatResponseModel
- Make `isPendingConfirmation<{startedWaitingAt: number}> | undefined`
to encode the time when the response started waiting for confirmation.
- Add a `confirmationAdjustedTimestamp` that can be used to reflect the
duration a chat response was waiting for user input vs working.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive timing information to the chat model system to better track when chat responses start, complete, and wait for user confirmation. The changes enable more accurate duration calculations that account for time spent waiting for user input versus time spent actively generating content.
Key Changes
- Added public
timestampproperty toIChatModelandIChatResponseModelto record creation time - Added
completedAttimestamp onIChatResponseModelto track when responses finish - Enhanced
isPendingConfirmationto includestartedWaitingAttimestamp for tracking confirmation wait periods - Introduced
confirmationAdjustedTimestampobservable that adjusts the response timestamp to exclude user confirmation wait time
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/common/chatModel.test.ts | Adds comprehensive test suite for timestamp and confirmationAdjustedTimestamp behavior, including simulation of pending confirmation states using fake timers |
| src/vs/workbench/contrib/chat/common/chatModel.ts | Implements timing infrastructure with timestamp tracking, state-based completion tracking via ResponseModelState enum, and confirmation-adjusted timestamp calculation; updates serialization to persist timing data |
| src/vs/base/common/types.ts | Adds WithDefinedProps utility type to enforce explicit property definition in objects satisfying interfaces with optional properties |
Comment on lines
+290
to
+305
| const toolState = observableValue<any>('state', { type: 0 /* IChatToolInvocation.StateKind.WaitingForConfirmation */ }); | ||
| const toolInvocation = { | ||
| kind: 'toolInvocation', | ||
| invocationMessage: 'calling tool', | ||
| state: toolState | ||
| } as Partial<IChatToolInvocation> as IChatToolInvocation; | ||
|
|
||
| model.acceptResponseProgress(request, toolInvocation); | ||
|
|
||
| // Advance time while pending | ||
| clock.tick(2000); | ||
| // Timestamp should still be start (it includes the wait time while waiting) | ||
| assert.strictEqual(response.confirmationAdjustedTimestamp.get(), start); | ||
|
|
||
| // Resolve confirmation | ||
| toolState.set({ type: 3 /* IChatToolInvocation.StateKind.Completed */ }, undefined); |
There was a problem hiding this comment.
The magic numbers 0 and 3 used for IChatToolInvocation.StateKind make the code less readable and maintainable. The comments indicate these represent WaitingForConfirmation and Completed respectively, but using the actual enum values would be clearer.
Consider importing the enum and using the named values: IChatToolInvocation.StateKind.WaitingForConfirmation and IChatToolInvocation.StateKind.Completed.
21 tasks
roblourens
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timestampon the IChatModeltimestampand optionalcompletedAttimestamp onthe IChatResponseModel
isPendingConfirmation<{startedWaitingAt: number}> | undefinedto encode the time when the response started waiting for confirmation.
confirmationAdjustedTimestampthat can be used to reflect theduration a chat response was waiting for user input vs working.
cc @bpasero