Improve canSetExpressionValue check#268952
Merged
connor4312 merged 1 commit intomicrosoft:mainfrom Sep 30, 2025
Merged
Conversation
connor4312
approved these changes
Sep 30, 2025
Member
|
Thanks for the contribution! |
lramos15
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I met unexpected behavior when cmake-tools extensiond din't send
supportsSetVariableorsupportSetExpressooncapabilities to VSCode, but UI still displayed an input box in the variables view. I added a simple check to handle this case.Before:
After: