Fix the type incompatibility issue in the MCP HTTP server handler#268548
Merged
connor4312 merged 3 commits intomicrosoft:mainfrom Sep 26, 2025
bwateratmsft:bwateratmsft/undici
Merged
Fix the type incompatibility issue in the MCP HTTP server handler#268548connor4312 merged 3 commits intomicrosoft:mainfrom bwateratmsft:bwateratmsft/undici
connor4312 merged 3 commits intomicrosoft:mainfrom
bwateratmsft:bwateratmsft/undici
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type incompatibility issue in the MCP HTTP server handler by introducing a common response interface and updating method signatures to use it consistently across both Node.js and common implementations.
- Introduces a
CommonResponseinterface to handle slight type differences between undici's Response and the standard Response type - Updates all Response type references to use the new
CommonResponseinterface - Simplifies the Node.js fetch implementation by returning undici's response directly with type casting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/api/common/extHostMcp.ts | Defines CommonResponse interface and updates all method signatures to use it instead of standard Response |
| src/vs/workbench/api/node/extHostMcpNode.ts | Updates Node.js implementation to return CommonResponse and simplifies fetch logic by removing manual Response construction |
connor4312
reviewed
Sep 26, 2025
connor4312
approved these changes
Sep 26, 2025
Tyriar
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a type incompatibility bug introduced by #268488 / #268524.