mcp: ensure tool refresh finishes after dynamic tool call#268025
Merged
connor4312 merged 1 commit intomainfrom Sep 23, 2025
Merged
mcp: ensure tool refresh finishes after dynamic tool call#268025connor4312 merged 1 commit intomainfrom
connor4312 merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that tool refresh operations complete after dynamic tool calls in the MCP (Model Context Protocol) server implementation. The change addresses an issue where dynamic tool calls could complete before the server had finished refreshing its tool list, potentially causing synchronization problems.
Key changes:
- Added
awaitToolRefresh()method to wait for tool refresh completion - Updated both
call()and_callWithProgress()methods to wait for tool refresh after tool execution - Refactored
_callWithProgress()to use async/await pattern for better error handling
lszomoru
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #261611