Fix memory leak with installing cursor change position listener #267799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... for the case when user has configured relative line numbers. 1) this wrapping method can be called multiple time when any configuration setting changes, so now multiple listeners are installed 2) unfortunately they also create additiional work which may lead to performance degradation we only need maximum 1 listener installed at a time
aiday-mar
previously approved these changes
Dec 16, 2025
aiday-mar
approved these changes
Dec 16, 2025
bpasero
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for the case when user has configured relative line numbers.
we only need maximum 1 listener installed at a time