fix: set edit context to undefined in dispose#256965
Merged
aiday-mar merged 1 commit intomicrosoft:mainfrom Jul 21, 2025
Merged
fix: set edit context to undefined in dispose#256965aiday-mar merged 1 commit intomicrosoft:mainfrom
aiday-mar merged 1 commit intomicrosoft:mainfrom
Conversation
aiday-mar
approved these changes
Jul 21, 2025
deepak1556
approved these changes
Jul 21, 2025
|
Hello! Please, review and merge #154465 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a memory leak related to edit context.
When opening and closing a text editor, the number of
EditContextsseems to increase each time. Setting theeditContextproperty toundefinedin thedisposefunction seems to solve this issue.Test Script
Before
The number of edit contexts when opening and closing a text editor 97 times grows from 2 to 99:
After
The number of edit contexts when opening and closing a text editor 97 times stays constant: