refactor(terminal): introduce ITerminalLaunchResult interface#256284
Merged
Tyriar merged 4 commits intomicrosoft:mainfrom Jul 17, 2025
Merged
refactor(terminal): introduce ITerminalLaunchResult interface#256284Tyriar merged 4 commits intomicrosoft:mainfrom
Tyriar merged 4 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
need to know whether the
But I think the code I mentioned above will not contribute to the VSCode repository. |
Member
|
Interesting. Note that the feature there is very much experimental and is likely to be tweaked. You probably don't want to depend upon it until the API is finalized tbh. |
Tyriar
previously approved these changes
Jul 17, 2025
amunger
previously approved these changes
Jul 17, 2025
rzhao271
approved these changes
Jul 17, 2025
Tyriar
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The commit introduces a new interface
ITerminalLaunchResultto replace the previously used inline return type{ injectedArgs: string[] }in various terminal process-related methods.When I want to add an attribute to the return type of
start, I found that I have changed many files, so I want to add this pr first.