Skip to content

Fix vscode.env.onDidChangeShell not firing in the webworker extension host #249824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 1 commit into from
Jun 2, 2025
Merged

Fix vscode.env.onDidChangeShell not firing in the webworker extension host #249824

Tyriar merged 1 commit into from
Jun 2, 2025

Conversation

@jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented May 26, 2025

Fixes #249823

@jeanp413 jeanp413 mentioned this pull request May 26, 2025
Closed
@jeanp413
Copy link
Contributor Author

jeanp413 commented May 27, 2025

cc @meganrogge as it's terminal related 🙂

@bpasero bpasero assigned meganrogge and unassigned bhavyaus May 27, 2025
@bpasero
Copy link
Member

bpasero commented May 27, 2025

I wonder how the one property can be different from the other 🤔

@jeanp413
Copy link
Contributor Author

jeanp413 commented May 27, 2025

Good point, currently remoteAuthority is empty for the web worker extension host context

@jeanp413
Copy link
Contributor Author

jeanp413 commented May 27, 2025

Seems that's intended for both webworker extension host and local extension host

vscode/src/vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts

Line 46 in 91b48e2

public readonly remoteAuthority = null;

vscode/src/vs/workbench/services/extensions/electron-sandbox/localProcessExtensionHost.ts

Line 93 in 91b48e2

public readonly remoteAuthority = null;

@bpasero
Copy link
Member

bpasero commented May 28, 2025 •
edited
Loading

We have a bit more uses of IExtHostContext.remoteAuthority in the workbench and I wonder if these are all disfunct and should be using the environment service, do you want to adopt the others too?

@jeanp413
Copy link
Contributor Author

jeanp413 commented May 28, 2025 •
edited
Loading

I see some usage in MainThreadMcp.ts but I think it's fine in that case as it's related where mpc servers are executed

@Tyriar Tyriar modified the milestones: June 2025, May 2025 Jun 2, 2025
@Tyriar Tyriar enabled auto-merge June 2, 2025 20:04
@Tyriar Tyriar merged commit 1e6e3fe into microsoft:main Jun 2, 2025
7 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Tyriar Tyriar Tyriar approved these changes

@meganrogge meganrogge meganrogge approved these changes

Assignees

@meganrogge meganrogge

Labels

None yet

Projects

None yet

Milestone

May 2025

Development

Successfully merging this pull request may close these issues.

vscode.env.onDidChangeShell not firing in the webworker extension host

5 participants

@jeanp413 @bpasero @Tyriar @meganrogge @bhavyaus